thefloweringash has quit [Ping timeout: 246 seconds]
edrex has quit [Remote host closed the connection]
danielrf[m] has quit [Remote host closed the connection]
sab7iryudpgf6[m] has quit [Remote host closed the connection]
edrex has joined #spectrum
thefloweringash has joined #spectrum
danielrf[m] has joined #spectrum
sab7iryudpgf6[m] has joined #spectrum
Irenes[m] has joined #spectrum
smrtak[m] has joined #spectrum
colemickens has joined #spectrum
cation21 has quit [Ping timeout: 272 seconds]
cation21 has joined #spectrum
cation21 has quit [Remote host closed the connection]
mvnetbiz_ has quit [*.net *.split]
mearon has quit [*.net *.split]
lukegb has quit [*.net *.split]
mearon has joined #spectrum
lukegb has joined #spectrum
mvnetbiz_ has joined #spectrum
cole-h has joined #spectrum
nicoo has quit [Remote host closed the connection]
nicoo has joined #spectrum
andi- has quit [Remote host closed the connection]
<qyliss>
I wonder how many times now I've read the virtio paper...
<cole-h>
Not enough
<qyliss>
never enough
andi- has joined #spectrum
<cole-h>
qyliss: Why is string.h included in `src/wayland-os.c` (Re: [PATCH wayland v2] Support virtio_wl display sockets)?
<qyliss>
memcpy or memcmp or something is in string.h for some reason I think
<qyliss>
Yeah memcmp
<qyliss>
Oh and memcpy
jacky has left #spectrum [#spectrum]
<cole-h>
I don't see any uses of memcmp/memcpy in wayland-os.c, though. virtio_wl.c, sure. Maybe I'm too rust in C/C++ to actually intuit what's happening.
<qyliss>
Ah, in that case it's probably a remnant of some debugging output
<qyliss>
I think at some point I memcpy()ed name to another buffer to null terminate it for easy debug printing
<qyliss>
Let me actually bring up the patch
<cole-h>
Want me to email that? (Just re-reading the patch atm)
<qyliss>
Yeah I don't think that needs to be there and neither does stdio.h
<cole-h>
That was my next question :P
<qyliss>
Email if you want but archiving that you pointed out I included some unnecessary headers probably doesn't matter too much :)
<cole-h>
:P
<qyliss>
(And I can just say you did in my v2 commentary)